- Notifications
You must be signed in to change notification settings - Fork928
fix: disable tests broken by daylight savings#10414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: disable tests broken by daylight savings#10414
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Current dependencies on/for this PR: This comment was auto-generated byGraphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
Oof. So either need to find locations without daylight savings or detect it and change the test accordingly? |
The other thought I had is to make that function also take the Anyway, what real value are we getting by asserting particular US/Ireland location offsets? Could also just replace those commented out test cases with Abu Dhabi and call it a day. |
Yea, I started the refactor to pass in a time, I also uses In the end though, the refactor to pass in a time kinda makes the function api a little strange since the In the end this is for insights to make sure the data is relative to the user's local timezone, and the buckets are daily. So I stopped spending time on getting the tests to be "perfect". 🤷 |
Timezone tests hard-code the offset, which is now different due to daylight savings