Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Prefix tmp directory for agent download with "coder"#1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfrommktempnice
Apr 15, 2022

Conversation

kylecarbs
Copy link
Member

This makes it easier to find the temporary dir for the coder binary.

This makes it easier to find the temporary dir for the coder binary.
@kylecarbskylecarbs requested a review fromf0sselApril 15, 2022 19:46
@kylecarbskylecarbs self-assigned thisApr 15, 2022
@codecov
Copy link

codecovbot commentedApr 15, 2022
edited
Loading

Codecov Report

Merging#1038 (e4822e1) intomain (88e30be) willdecrease coverage by0.25%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1038      +/-   ##==========================================- Coverage   67.54%   67.29%   -0.26%==========================================  Files         259      259                Lines       15059    15059                Branches      151      151              ==========================================- Hits        10172    10134      -38- Misses       3873     3903      +30- Partials     1014     1022       +8
FlagCoverage Δ
unittest-go-macos-latest53.40% <ø> (-0.41%)⬇️
unittest-go-postgres-66.65% <ø> (+<0.01%)⬆️
unittest-go-ubuntu-latest56.16% <ø> (-0.24%)⬇️
unittest-go-windows-202253.01% <ø> (+<0.01%)⬆️
unittest-js68.20% <ø> (ø)
Impacted FilesCoverage Δ
provisionersdk/agent.go100.00% <ø> (ø)
pty/start_other.go64.70% <0.00%> (-23.53%)⬇️
peerbroker/dial.go77.04% <0.00%> (-6.56%)⬇️
cli/cliui/agent.go77.19% <0.00%> (-5.27%)⬇️
coderd/parameter/compute.go74.07% <0.00%> (-4.45%)⬇️
peer/conn.go77.41% <0.00%> (-3.81%)⬇️
provisioner/echo/serve.go54.40% <0.00%> (-2.40%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
peer/channel.go83.23% <0.00%> (-1.74%)⬇️
peerbroker/proxy.go57.55% <0.00%> (-0.59%)⬇️
... and4 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update88e30be...e4822e1. Read thecomment docs.

@kylecarbskylecarbs merged commit104a3c6 intomainApr 15, 2022
@kylecarbskylecarbs deleted the mktempnice branchApril 15, 2022 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@f0sself0sself0ssel approved these changes

Assignees

@kylecarbskylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp