Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add frontend support for enabling automatic workspace updates#10375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 11 commits intomainfromjon/wsautoupdatefe
Oct 31, 2023

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedOct 21, 2023•
edited
Loading

This PR adds support for configuring an update policy for a workspace. Some behavior notes:

  • A tooltip is displayed in the workspace stats bar if your update policy is overriden by the template-level setting.
  • As long as the template policy does not mandate that the updates are enforced, the restart/start buttons will appear on the dashboard (and do not update to the latest version) regardless of whether you've toggled the workspace-level setting. It feels wrong to restrict the options of the user based on a setting that they personally decide to opt-in or not.

Workspace settings page:

Screenshot 2023-10-21 at 5 15 29 PM

Workspace Page (Regular User) -- Policy=Never TemplatePolicy=Always:

Screenshot 2023-10-21 at 5 32 13 PM

Workspace Page (Regular User) -- Policy=Always TemplatePolicy=Disabled:

Screenshot 2023-10-21 at 5 34 07 PM

fixes#7465

@sreya
Copy link
CollaboratorAuthor

@aslilac the one issue I'm seeing is that after I submit the form in the workspace settings page the whole form stays disabled until I refresh the page 🤔

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 29, 2023
@aslilacaslilac removed the staleThis issue is like stale bread. labelOct 30, 2023
@aslilac
Copy link
Member

I can't figure out how to reproduce the disabled form, but I'm happy to have a quick debugging session later

@sreyasreya requested a review fromaslilacOctober 30, 2023 23:44
import { Workspace } from "api/typesGenerated";
import {
AutomaticUpdates,
AutomaticUpdateses,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this name sounds like we hired gollum 😂

sreya reacted with laugh emoji
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh, I just noticed that this broke one of the storybook tests. check chromatic, but after that's fixed it should be good to go.

@sreyasreya requested a review fromaslilacOctober 31, 2023 19:28
@sreyasreya merged commitf4026ed intomainOct 31, 2023
@sreyasreya deleted the jon/wsautoupdatefe branchOctober 31, 2023 22:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace "automatic update" front end settings
3 participants
@sreya@aslilac@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp