Current dependencies on/for this PR:

• main
  • PRfeat: add tailnet and agent API definitions #10324 👈

This comment was auto-generated byGraphite.

Customers use the HTTP endpoint of this to manually send logs.

How do we imagine the implementation logic that forks the gRPC and HTTP handler in coderd?

I was thinking an Agent API service, with an HTTP wrapper for the "legacy" methods. If logging isn't going to be deprecated we could leave the existing HTTP handler for that on the main API. I haven't looked at the code in detail, so it may or may not make sense for the dRPC to share code with the HTTP; either is fine.

One thing I've just added, for those watching, are messages to the Coordinator RPC for adding and removing subscriptions (now called Tunnels).

I didn't realize when I originally created the API that there is a second wire protocol that Workspace Proxies use to communicate with Coderd, and I'd like to cover that use case as well such that there is a single wire protocol for tailnet.

Please look at the RFC for more details:https://www.notion.so/coderhq/Agent-Tailnet-APIs-386764332c134e0981946cefe657fd83?pvs=4#9f55e1837ecc4c9ea93cf5760f20c007

I was thinking an Agent API service, with an HTTP wrapper for the "legacy" methods. If logging isn't going to be deprecated we could leave the existing HTTP handler for that on the main API. I haven't looked at the code in detail, so it may or may not make sense for the dRPC to share code with the HTTP; either is fine.

I think it'd be possible to share a lot of the code paths by accepting JSON requests and unmarshaling them into protobuf messages, e.g.https://pkg.go.dev/google.golang.org/protobuf/encoding/protojson

This way we don't even need to duplicate the representation, generating the API documentation is a question-mark, though.

I don't think protojson encoding/decoding is compatible with standard encoding/json. So, getting our existing message formats to decode into protobuf is a tall order, and would likely gum up the new API with weird legacy stuff

I'm not sure I'd consider the HTTP routes legacy... many of our customers (whether we like it or not) have cURL'd our agent HTTP endpoints to make some kinda magic happen, and we do it for things likegitauth.

This obviously doesn't prevent that though, so I'm good with it!