NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: update semantic types#1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

greyscaled merged 5 commits intomainfromvapurrmaid/semantic-types

Apr 15, 2022

Merged

chore: update semantic types#1030

greyscaled merged 5 commits intomainfromvapurrmaid/semantic-types

Apr 15, 2022

Conversation

Copy link

Contributor

greyscaled commentedApr 15, 2022•
edited
Loading

Summary:

PRs like#1025 feel like they deserve anexample: type, but we didn't have one.
Furthermore our definitions for correct, fix, and hotfix were stale.

chore: update semantic types

4fce547

Summary:PRs like#1025 feel like they deserve a doc: type, but we didn't have one.Furthermore our definitions for correct and fix were stale.

greyscaled commented

Apr 15, 2022

View reviewed changes

.github/semantic.yaml OutdatedShow resolvedHide resolved

Update .github/semantic.yaml

0b89d73

greyscaled self-assigned this

Apr 15, 2022

Copy link

codecovbot commentedApr 15, 2022•
edited
Loading

Codecov Report

Merging#1030 (a342411) intomain (88e30be) willincrease coverage by9.66%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1030      +/-   ##==========================================+ Coverage   57.70%   67.37%   +9.66%==========================================  Files         259      259                Lines       15059    15059                Branches      151      151              ==========================================+ Hits         8690    10146    +1456+ Misses       5426     3893    -1533- Partials      943     1020      +77

Flag	Coverage Δ
unittest-go-macos-latest	`53.56% <ø> (+0.09%)`	⬆️
unittest-go-postgres-	`66.62% <ø> (?)`
unittest-go-ubuntu-latest	`56.29% <ø> (-0.02%)`	⬇️
unittest-go-windows-2022	`53.03% <ø> (+0.04%)`	⬆️
unittest-js	`68.20% <ø> (ø)`

Impacted Files	Coverage Δ
peerbroker/listen.go	`84.16% <0.00%> (-3.34%)`	⬇️
peerbroker/proxy.go	`57.55% <0.00%> (-0.59%)`	⬇️
peer/conn.go	`79.69% <0.00%> (-0.26%)`	⬇️
peer/channel.go	`83.81% <0.00%> (+0.57%)`	⬆️
coderd/workspaceagents.go	`59.82% <0.00%> (+1.33%)`	⬆️
coderd/templates.go	`62.29% <0.00%> (+1.63%)`	⬆️
cli/cliui/provisionerjob.go	`78.57% <0.00%> (+2.14%)`	⬆️
provisioner/echo/serve.go	`56.80% <0.00%> (+2.39%)`	⬆️
provisionerd/provisionerd.go	`80.73% <0.00%> (+2.64%)`	⬆️
coderd/provisionerdaemons.go	`63.46% <0.00%> (+4.11%)`	⬆️
... and9 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update88e30be...a342411. Read thecomment docs.