Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: reorganize template docs#10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 41 commits intomainfromtemplates-docs
Oct 17, 2023
Merged

docs: reorganize template docs#10297

matifali merged 41 commits intomainfromtemplates-docs
Oct 17, 2023

Conversation

matifali
Copy link
Member

@matifalimatifali commentedOct 16, 2023•
edited
Loading

@bpmct, it looks like#9139 was merged toemplates-docs.
This PR merges it tomain.

bpmctand others added6 commitsJuly 28, 2023 04:12
* Reorg, updated/new screenshots, consistent terminology* First pass* Another pass* Added integration section* New outline for template pages, small updates* Revised outline for templates, added tutorial* First pass at tutorial* Some feedback from Ben.* Update docs/workspaces.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/workspaces.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/workspaces.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Fixed typos* Expanded tutorialI have read the CLA Document and I hereby sign the CLA* New screenshots, improved tutorial, revised anatomy* Improved tutorial. Anatomy is now a guided tour.* First pass at guided tour* Updated authentication info* Reorganized the guided tour* Edited more template pages* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tutorial.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Update docs/templates/tour.mdCo-authored-by: Muhammad Atif Ali <matifali@live.com>* Revised devcontainers and docker-in-workspaces* Edited and added screenshots* Prepared first draft, except docs/templates/open-in-coder.md* Fix typo* remove legacy parameters and migration guide* Use coder templates create* Added screenshot for workspace template variables* Made it prettier* Fixed minor typos and markdown problems* edits to repairing workspaces* fix broken links in product* Added troubleshooting, minor corrections.* fix terminal links* fmt---------Co-authored-by: Muhammad Atif Ali <matifali@live.com>Co-authored-by: Ben Potter <me@bpmct.net>Co-authored-by: Atif Ali <atif@coder.com>
@matifalimatifali requested a review frombpmctOctober 16, 2023 20:54
@matifali
Copy link
MemberAuthor

Hi@matifali and@ericpaulsen, as this is a major refactor, I would like you to review if we have accidentally removed some docs. The old PR#9139 was based on a very old branch, so I had to make some decisions on what to keep.

@matifali
Copy link
MemberAuthor

@bpmct I have also checked the docs preview on coder.com and they look fine.

@marcpaq
Copy link
Contributor

marcpaq commentedOct 17, 2023•
edited
Loading

@matifali I've taken a look at the content changes indocs, in the PR and in the dev.coder.com docs preview. Except for my comments above, it looks good to me.

I've also quickly reviewed the links insite/src/pages/*/*.tsx, which seem appropriate (but I'm not an expert on this code).

Nice merge. Thanks!

matifali reacted with thumbs up emoji

@matifaliGraphite App
Copy link
MemberAuthor

Thanks, I have addressed all your comments.

Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM as long as you tested w/ the docs preview

marcpaq and matifali reacted with thumbs up emoji
@matifalimatifalienabled auto-merge (squash)October 17, 2023 14:35
@matifali
Copy link
MemberAuthor

links check pass:https://github.com/coder/coder/actions/runs/6548788879/job/17784246419
manually tested docs

@matifalimatifalienabled auto-merge (squash)October 17, 2023 14:41
@matifalimatifali merged commita49e6b8 intomainOct 17, 2023
@matifalimatifali deleted the templates-docs branchOctober 17, 2023 14:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@marcpaqmarcpaqmarcpaq left review comments

@bpmctbpmctbpmct approved these changes

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@matifali@marcpaq@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp