Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(scaletest/templates): run all scenarios even on failure#10290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

We also end all failed phases and add theerror tag in Grafana.

We also end all failed phases and add the `error` tag in Grafana.
@mafredrimafredri self-assigned thisOct 16, 2023
Comment on lines +66 to +74
# Debug scenarios, for testing the runner.
"debug:success")
maybedryrun "$DRY_RUN" sleep 10
status=0
;;
"debug:error")
maybedryrun "$DRY_RUN" sleep 10
status=1
;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

       _           _ __ (_) ___ ___ | '_ \| |/ __/ _ \| | | | | (_|  __/|_| |_|_|\___\___|

mafredri reacted with heart emoji

wait_baseline "${SCALETEST_PARAM_LOAD_SCENARIO_BASELINE_DURATION}"
done

if ((${#failed} > 0)); then
log "Load scenarios failed: ${!failed[*]}"
for scenario in "${!failed[@]}"; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't know you could do this :o

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup, it's the syntax for accessing associative array keys. 💪🏻 (I much prefer the Zsh way thoughfor scenario in ${(k)failed} or evenfor scenario code in ${(kv)failed}. 😜)

@mafredrimafredri merged commit43f26df intomainOct 16, 2023
@mafredrimafredri deleted the mafredri/feat-scaletest-run-all-scenarios-log-failures branchOctober 16, 2023 15:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mafredri@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp