- Notifications
You must be signed in to change notification settings - Fork928
refactor: strong type for getFormHelpers name#1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -17,8 +17,13 @@ interface FormHelpers { | ||
helperText?: string | ||
} | ||
export const getFormHelpers = <T>(form: FormikContextType<T>, name: keyof T, error?: string): FormHelpers => { | ||
if (typeof name !== "string") { | ||
throw new Error(`name must be type of string, instead received '${typeof name}'`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. What happens if somehow this gets thrown in production? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. That's a desirable case at this stage. We don't yet have an error boundary ported (#1013 ), but you'd hit that. | ||
} | ||
// getIn is a util function from Formik that gets at any depth of nesting | ||
// and is necessary for the types to work | ||
const touched = getIn(form.touched, name) | ||
const errors = error ?? getIn(form.errors, name) | ||
return { | ||