- Notifications
You must be signed in to change notification settings - Fork928
example: added docker local workspace#1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary:PRs like#1025 feel like they deserve a doc: type, but we didn't have one.Furthermore our definitions for correct and fix were stale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
┌──────────────────────────────────────────────────────────────────┐│ RESOURCE STATUS ACCESS │├──────────────────────────────────────────────────────────────────┤│ docker_container.workspace ephemeral ││ └─ dev (linux, amd64) ⦾ connecting [0s] coder ssh colin │├──────────────────────────────────────────────────────────────────┤│ docker_volume.coder_volume ephemeral │└──────────────────────────────────────────────────────────────────┘The colin workspace has been created!colin at coder in ~/Projects/coder/coder/examples/docker-local (task/docker-workspace-example)$ coder ssh colincoder@d982a97c7cac:/$Works great!
Uh oh!
There was an error while loading.Please reload this page.
Could you try rebasing? I think I pushed a fix to allow actions to run for external prs. |
@coadler seems like some of the tests are failing because of missing env variables. I guess since its a fork the CI job does not have access to the same env vars as the ones in the main repo, which of course is good. But then it would maybe be helpful to somehow exclude these jobs from forks if possible? |
@ntimo this is our first external fork, so we'll be removing those steps from requiring the variables! I'll fix that now. |
Summary:PRs like#1025 feel like they deserve a doc: type, but we didn't have one.Furthermore our definitions for correct and fix were stale.
Should be fixed now in#1048. Apologies for the delay! |
This PR adds a new example template that can be used with the
coder start --devmode to provision a workspace container on the local machine.