NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: display health alert in`DeploymentBannerView`#10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

aslilac merged 9 commits intomainfromhealth-badge

Oct 13, 2023

Merged

fix: display health alert in`DeploymentBannerView`#10193

aslilac merged 9 commits intomainfromhealth-badge

Oct 13, 2023

Conversation

Copy link

Member

aslilac commentedOct 10, 2023•
edited
Loading

Closes#9692

fix: display health alert inDeploymentBannerView

3893821

github-actionsbot assignedaslilac

Oct 10, 2023

aslilac added4 commits

October 11, 2023 23:06

oh no!

5682238

Merge branch 'main' into health-badge

f59d467

Merge branch 'main' into health-badge

8cca491

:)

bee5ecb

aslilac requested review froma team andBrunoQuaresma and removed request fora team

October 12, 2023 23:14

aslilac marked this pull request as ready for review

October 12, 2023 23:14

aslilac added3 commits

October 12, 2023 23:18

fill in story with real-er stuff

9600c49

move to testHelpers/entities

78f701c

🧹

626f4f6

aslilac requested a review fromParkreiner

October 12, 2023 23:45

Parkreiner approved these changes

Oct 13, 2023

View reviewed changes

Copy link

Member

Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have a few comments, but nothing block-worthy. Looks really good!

site/src/api/api.tsShow resolvedHide resolved

site/src/api/queries/deployment.tsShow resolvedHide resolved

site/src/components/HelpTooltip/HelpTooltip.tsx

		@@ -242,7 +240,7 @@ const styles = {
		marginBottom: theme.spacing(1),
		color: theme.palette.text.primary,
		fontSize: 14,
		lineHeight: "120%",
		lineHeight: "150%",

Copy link

Member

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm wondering if this could be changed to just1.5, to work better with CSS inheritance

Copy link

MemberAuthor

aslilacOct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure what you mean by "work better with CSS inheritance".150% and1.5 mean the same thing in CSS. 😅 and I prefer percent, because the unit makes it clearer what is happening imo.

Copy link

Member

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wish they were the same, butthey aren't

Copy link

MemberAuthor

aslilacOct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why is CSS like this 😭

site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsxShow resolvedHide resolved

site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx OutdatedShow resolvedHide resolved

site/src/components/PopoverContainer/PopoverContainer.stories.tsxShow resolvedHide resolved

site/src/testHelpers/entities.ts OutdatedShow resolvedHide resolved

🧹

5785c4d

aslilac merged commitcbc0c39 intomain

Oct 13, 2023

aslilac deleted the health-badge branch

October 13, 2023 16:39

github-actionsbot locked and limited conversation to collaborators

Oct 13, 2023

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: display health alert in`DeploymentBannerView`#10193

fix: display health alert in`DeploymentBannerView`#10193

Uh oh!

Conversation

aslilac commentedOct 10, 2023•
edited
Loading

Uh oh!

Uh oh!

Parkreiner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

aslilacOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

aslilacOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

fix: display health alert inDeploymentBannerView#10193

fix: display health alert inDeploymentBannerView#10193

Uh oh!

Conversation

aslilac commentedOct 10, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Parkreiner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

aslilacOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

ParkreinerOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

aslilacOct 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: display health alert in`DeploymentBannerView`#10193

fix: display health alert in`DeploymentBannerView`#10193

aslilac commentedOct 10, 2023•
edited
Loading