Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add archive column to template versions#10178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 5 commits intomainfromstevenmasley/add_archive_column
Oct 10, 2023

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedOct 10, 2023•
edited
Loading

What this does

Adds thearchived column on template versions. cli/api changes coming in another PR

return version
}

func TestArchiveVersions(t *testing.T) {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The cli/api branch has a test at the coderd layer, adding this test at the db layer since the coderd layer of this feat does not exist yet.

johnstcn reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's no harm to have some database-layer tests.

@EmyrkEmyrk requested a review fromjohnstcnOctober 10, 2023 15:09
@EmyrkEmyrk merged commit69d13f1 intomainOct 10, 2023
@EmyrkEmyrk deleted the stevenmasley/add_archive_column branchOctober 10, 2023 15:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 10, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp