- Notifications
You must be signed in to change notification settings - Fork928
feat(cli): add --parameter flag to exp scaletest command#10132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| richParameters, err := prepWorkspaceBuild(inv, client, prepWorkspaceBuildArgs{ | ||
| Action: WorkspaceCreate, | ||
| Template: tpl, | ||
| NewWorkspaceName: "scaletest-%", // TODO: the scaletest runner will pass in a different name here. Does this matter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mtojek Does the value here only matter for showing the plan output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, only for dry-run purposes. Not sure what happens if there is a workspace with such name exists. In the worst case, you can append a random number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok!
| richParameters, err := prepWorkspaceBuild(inv, client, prepWorkspaceBuildArgs{ | ||
| Action: WorkspaceCreate, | ||
| Template: tpl, | ||
| NewWorkspaceName: "scaletest-%", // TODO: the scaletest runner will pass in a different name here. Does this matter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, only for dry-run purposes. Not sure what happens if there is a workspace with such name exists. In the worst case, you can append a random number.
| @@ -525,6 +525,8 @@ func (r *RootCmd) scaletestCreateWorkspaces() *clibase.Cmd { | |||
| useHostUser bool | |||
| parameterFlags workspaceParameterFlags | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI This may also pull--build-options, not sure if you want to support them too. Probably not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't see a need at present. We don't rebuild workspaces in this command, only create.
This PR adds support for passing parameters to workspaces built by
exp scaletest.