NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: Add Footer to every page with nav#1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

presleyp merged 3 commits intomainfromfooter/presleyp/977

Apr 14, 2022

Merged

feat: Add Footer to every page with nav#1009

presleyp merged 3 commits intomainfromfooter/presleyp/977

Apr 14, 2022

Conversation

Copy link

Contributor

presleyp commentedApr 14, 2022

We had some pages with the footer and some without, so I looked at v1 and saw that wherever the nav shows, the footer does too. (Now the only place we still need the footer is the login page, and we have a ticket for that.)

add Footer to AuthAndNav
rename AuthAndNav to AuthAndFrame - I was thinking the nav and footer "frame" the page but I'm open to naming suggestions
remove Footer where it would be doubled

presleyp added3 commits

April 13, 2022 20:55

Add Footer to AuthAndNav, rename

2e0a650

Fix in preferences layout

74211bb

Remove double footer

27c06fd

presleyp requested a review froma team as acode owner

April 14, 2022 16:39

presleyp self-assigned this

Apr 14, 2022

Copy link

codecovbot commentedApr 14, 2022•
edited
Loading

Codecov Report

Merging#1009 (27c06fd) intomain (300c6d0) willincrease coverage by0.31%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main    #1009      +/-   ##==========================================+ Coverage   66.42%   66.74%   +0.31%==========================================  Files         247      250       +3       Lines       14635    14817     +182       Branches      131      131              ==========================================+ Hits         9722     9890     +168- Misses       3932     3937       +5- Partials      981      990       +9

Flag	Coverage Δ
unittest-go-macos-latest	`53.72% <ø> (+0.02%)`	⬆️
unittest-go-postgres-	`66.58% <ø> (+0.23%)`	⬆️
unittest-go-ubuntu-latest	`56.44% <ø> (+0.03%)`	⬆️
unittest-go-windows-2022	`53.29% <ø> (?)`
unittest-js	`61.34% <0.00%> (+0.10%)`	⬆️

Impacted Files	Coverage Δ
site/src/AppRouter.tsx	`0.00% <0.00%> (ø)`
site/src/components/AuthAndFrame/AuthAndFrame.tsx	`0.00% <0.00%> (ø)`
site/src/components/Page/index.tsx	`0.00% <ø> (ø)`
site/src/components/Preferences/Layout.tsx	`0.00% <0.00%> (ø)`
...ages/templates/[organization]/[template]/index.tsx	`0.00% <ø> (ø)`
site/src/pages/templates/index.tsx	`0.00% <ø> (ø)`
site/src/pages/workspaces/[workspace].tsx	`0.00% <ø> (ø)`
provisionersdk/serve.go	`35.13% <0.00%> (-8.11%)`	⬇️
peerbroker/dial.go	`77.04% <0.00%> (-6.56%)`	⬇️
provisionersdk/transport.go	`78.72% <0.00%> (-6.39%)`	⬇️
... and15 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update300c6d0...27c06fd. Read thecomment docs.