NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: use workspace name as arg in`coder workspaces create`#1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 4 commits intomainfromcolin/workspace-create-name

Apr 14, 2022

Merged

chore: use workspace name as arg in`coder workspaces create`#1007

coadler merged 4 commits intomainfromcolin/workspace-create-name

Apr 14, 2022

Conversation

Copy link

Contributor

coadler commentedApr 14, 2022

Fixes#1003

coadler requested a review fromkylecarbs

April 14, 2022 16:34

coadler self-assigned this

Apr 14, 2022

Copy link

codecovbot commentedApr 14, 2022•
edited
Loading

Codecov Report

Merging#1007 (35eac1f) intomain (7090227) willdecrease coverage by0.48%.
The diff coverage is58.82%.

@@            Coverage Diff             @@##             main    #1007      +/-   ##==========================================- Coverage   67.01%   66.52%   -0.49%==========================================  Files         253      250       -3       Lines       14941    14759     -182       Branches      135      135              ==========================================- Hits        10013     9819     -194- Misses       3938     3952      +14+ Partials      990      988       -2

Flag	Coverage Δ
unittest-go-macos-latest	`53.54% <58.82%> (-0.04%)`	⬇️
unittest-go-postgres-	`66.50% <58.82%> (-0.33%)`	⬇️
unittest-go-ubuntu-latest	`56.15% <58.82%> (-0.03%)`	⬇️
unittest-go-windows-2022	`?`
unittest-js	`61.61% <ø> (ø)`

Impacted Files	Coverage Δ
cli/templatecreate.go	`46.92% <57.14%> (-0.51%)`	⬇️
cli/workspacecreate.go	`56.66% <59.25%> (+1.40%)`	⬆️
cli/configssh.go	`61.41% <0.00%> (-7.09%)`	⬇️
coderd/parameter/compute.go	`74.07% <0.00%> (-6.67%)`	⬇️
coderd/httpapi/httpapi.go	`66.25% <0.00%> (-6.25%)`	⬇️
cli/cliui/agent.go	`77.19% <0.00%> (-5.27%)`	⬇️
pty/ptytest/ptytest.go	`89.65% <0.00%> (-5.18%)`	⬇️
coderd/provisionerdaemons.go	`60.89% <0.00%> (-3.61%)`	⬇️
coderd/workspaceagents.go	`59.82% <0.00%> (-3.58%)`	⬇️
cli/templateinit.go	`58.62% <0.00%> (-3.45%)`	⬇️
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7090227...35eac1f. Read thecomment docs.