- Notifications
You must be signed in to change notification settings - Fork906
chore: Initial GHA workflow#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Few minor things! Once fixed, feel free to merge!
.eslintignore Outdated
| ############################################################################### | ||
| .cache | ||
| vendor | ||
| product/coder/cmd/coderd/config.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should be able to cleanup a few of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ooh, ya, good point - I'll clear these out to just the ones weactually need (right now, justnode_modules).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Cleaned up in6f0a43e
package.json Outdated
| "name": "coder-v2", | ||
| "version": "0.0.1", | ||
| "description": "Coder V2 (Workspaces V2)", | ||
| "main": "index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably should remove the main for now, since it seems unlikely we'll have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Totally, thanks for catching this! Removed indb32104
package.json Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "name": "coder-v2", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Feels like this version will get outdated really fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point, I realized we don't have a version incoder/m's rootpackage.json, so I'll leave out here too. We can always add back later, but better to simplify as you suggested 👍
Also removed this indb32104
Thanks for the review and suggestions,@kylecarbs ! |
Uh oh!
There was an error while loading.Please reload this page.
This implements an initial GitHub Actions workflow for us - to be run on PRs and on
maincommits.This just implements a really simple
style/fmtcheck - runningprettieron theREADME.md.I assumed we'll stick with using a top-level
Makefilefor commands like inmandlink- but open to alternatives, too!Since I was adding a
package.jsonandnode_modulesfor this, I realized we were missing.gitignores, so I added some a subset of the ignore files fromcoder/mTODO:
README.mdneeds formatting