- Notifications
You must be signed in to change notification settings - Fork928
Closed
Description
Background
Coder'sgitauth
feature allows admins to link aGit Provider. When a developer goes togit clone
a workspace, they can authenticate via Coder instead of having to manually manage tokens/SSH keys.
One feature of gitauth isregex matching, which allows Coder to determine what git provider to use for specificgit
repositories (e.g. bitbucket.com -> provider 1, github.com -> provider 2). When there is not a valid regex match, Coder throws a pretty nasty error:
node ➜~ $ git clone https://github.com/coder/idkCloning into'idk'...ERROR: No git provider foundfor URL"https://github.com" error: unable toread askpass response from'/tmp/coder.8MaM80/coder'Usernamefor'https://github.com':
There are some cases where the user may wish to use their own authentication, such as for a personal repo (dotfiles).
Potential solutions
- Instead of calling out negative matches, only call out positive matches to indicate gitauth is being used
- Make message more passive, avoid "error" terminology.
No matching git providers foundin Coder. Falling back to git authentication
Perhaps we could also cover this in verbose agent or server logging, to identify why a provider isn't being matched. This is a nice-to-have
Metadata
Metadata
Assignees
Labels
No labels