- Notifications
You must be signed in to change notification settings - Fork928
Description
So, there are a lot admins on our dev deployment and a lot of people that can make template changes.
None of our templates are updated automatically in CI—not even the primary dogfood template called "coder". This was an intentional decision by@kylecarbs so we can dogfood in a manner similar to our users.
Thecoder
template can be pulled down by any admin and edited by anyone. There is no built in change management, so it's very easy for two people to run edits on the same template simultaneously and overwrite each other's work. Furthermore, the product doesn't make who you seek template support from clear. There is the "created by" but that is an unchangeable value and will almost certainly fall out of date. In dogfood, I'd bet many don't know that they should ping Kyle and not Dean.
This is especially top of mind for me as I work on a new dogfood template. I don't want anyone other than me editing the template and I want everyone contacting me if they have issues.
Proposal
- Each template has owners that are users.
- These owners are listed in replacement of "Created By" on the template pages.
- The user that creates the template is the first template owner.
- Only the template owners can make changes to the template, not even the admin. Of course, the admin can add themselves as an owner to make changes.
- We show the template owner in the build log as well, e.g "Contact X if for workspace support"
- In mature deployment, the template owner would be the CI machine user
The owners function as both a mutex and support clarity.