Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(.devcontainer): check if ssh folder exists in post_create#19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 5 commits intomainfrommafredri-patch-1
Oct 8, 2025

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedSep 26, 2025
edited
Loading

Script assumed~/.ssh exists which is not always the case.

echo"🔑 Installing SSH configuration..."
rsync -a /mnt/home/coder/.ssh/~/.ssh/
if [[-d /mnt/home/coder/.ssh ]];then
rsync -a /mnt/home/coder/.ssh/~/.ssh/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

suggestion: else echo "none found" or something

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

Add warning message if SSH directory is not found
@mafredrimafredrienabled auto-merge (squash)September 26, 2025 14:46
Ensure correct permissions for the SSH directory.
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 4, 2025
auto-merge was automatically disabledOctober 7, 2025 00:07

Pull request was closed

@mafredrimafredri reopened thisOct 7, 2025
@mafredrimafredrienabled auto-merge (squash)October 7, 2025 09:02
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelOct 8, 2025
@matifali
Copy link
Member

@mafredri looks like lint failed

In ./.devcontainer/scripts/post_create.sh line 13:if [[ -d /mnt/home/coder/.ssh ]]; then           ^---------------------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
mafredri reacted with thumbs up emoji

@mafredrimafredri merged commit8274251 intomainOct 8, 2025
30 checks passed
@mafredrimafredri deleted the mafredri-patch-1 branchOctober 8, 2025 07:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@bpmctbpmctbpmct approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@mafredri@matifali@johnstcn@bpmct@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp