- Notifications
You must be signed in to change notification settings - Fork1k
Description
Currently, the first time Coder Desktop dials/api/v2/tailnet
is within the mainController.Run
loop:
Line 1420 infb0e7a2
tailnetClients,err:=c.Dialer.Dial(c.ctx,c.ResumeTokenCtrl) |
This means the tunnel sends theStartResponse
withsuccess
set totrue
without knowing whether or not it was able to dial the coordination endpoint. This results in a poor UX if we're not able to dial it initially; Coder Connect appears functional but is not - the only sign something went wrong is theNo workspaces
message, and N error logs, for each retry attempt.
Instead, we should fail fast, and send aStartResponse
withsuccess
set tofalse
if we fail to dial right after starting.