There seems to be a goroutine leak incoderd.(*api).workspaceAgentTurn.

This could be seen as two bugs:

1. Goroutine leak
2. Use of(*http.Request).Context() afterHijack in more than one place

Steps to Reproduce

0. Enable pprof for coder server
1. coder ssh dev
2. ctlr+d
3. Goto 1
4. Check pprof (go tool pprof -http=:8080 http://localhost:6060/debug/pprof/goroutine)

The leak is in part due to reliance on thehttp.Request context and use of websockets. The underlying websocket library calls(*http.Request).Hijack which disables context propagation.

This happens here:

And the following contexts will not cancel until the http handler completes:

We must avoid usingr.Context() after hijack, unless we are using it with the expectation that the http handler will exit (at which point the context will complete).

I'm unfamiliar with thepion/turn package, but another factor could be wrt how it handles connection closure, perhaps it does not propagate as we expect since we're not callingwsConn.Close() due to context reliance?

Similar reliance on request context after hijack is done elsewhere, we should rethink all of them. Example: