Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Site: PopoverTrigger is not keyboard-friendly for hover variant #14776

Open
Labels
s4Internal bugs (e.g. test flakes), extreme edge cases, and bug riskssiteArea: frontend dashboard
@Parkreiner

Description

@Parkreiner

Spurred by#14755. Making this mostly for documentation purposes; I don't expect this to take long, and I'm planning to address this tomorrow once#14755 is merged in

Issue

Lately, parts of the UI code have opted into this pattern for our Popovers:

<PopoverTrigger><Pill{...otherProps}/></PopoverTrigger>

When we madePopoverTrigger, I think the assumption was that it would always be used with<button> elements (and would inherit their keyboard focus behavior by default). OurPill (and our newFeatureStageBadge) components are just<div>s, though, and don't have any of those accessibility niceties. For any user who can only use a keyboard, this means that the tooltip information isalways unavailable, and they have zero ways of making the trigger trigger.

Proposed solution

PopoverTrigger should be updated so that when in its hover variant, all the correct keyboard properties are added to the child element if they weren't there already. The most important ones are going to betabIndex,onFocus, andonBlur.

Metadata

Metadata

Assignees

No one assigned

    Labels

    s4Internal bugs (e.g. test flakes), extreme edge cases, and bug riskssiteArea: frontend dashboard

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp