- Notifications
You must be signed in to change notification settings - Fork927
Closed
Description
Did a quick scan for our currentuseEffect
calls, and a couple of concerns jumped out at me. To be clear, I don't know if these should block enablingStrictMode
. These are bugs that our tests aren't catching, but the point ofStrictMode
is to highlight that these bugs exist. The issues still exist for the end user, whether we're usingStrictMode
or not
useProxyLatency
- Doesn't clean up its
PerformanceObserver
- Didn't read through the whole file, but my understanding is that each time the effect re-fires, we'll get a new observer that will keep updating state that we don't care about anymore
- Doesn't clean up its
MonacoEditor
- Not sure if we want to cancel remeasuring the fonts when the theme changes
TemplateVersionEditorPage
- The TAR reader has a race condition when the data changes
- Initialize the file tree for data 1 and kick off an async process for reading it
- Data changes and kicks off a new effect, and we now do the same thing for data 2
- Data 2 finishes reading and updates state first because it's shorter
- Data 1 then finishes and updates state as well, writing stale data
- The TAR reader has a race condition when the data changes
WorkspaceBuildProgress
- Doesn't clear out a timeout
Originally posted by@Parkreiner in#13399 (comment)