Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Clean up buggyuseEffect calls #13422

Closed
Labels
siteArea: frontend dashboard
@aslilac

Description

@aslilac

Did a quick scan for our currentuseEffect calls, and a couple of concerns jumped out at me. To be clear, I don't know if these should block enablingStrictMode. These are bugs that our tests aren't catching, but the point ofStrictMode is to highlight that these bugs exist. The issues still exist for the end user, whether we're usingStrictMode or not

  • useProxyLatency
    • Doesn't clean up itsPerformanceObserver
    • Didn't read through the whole file, but my understanding is that each time the effect re-fires, we'll get a new observer that will keep updating state that we don't care about anymore
  • MonacoEditor
    • Not sure if we want to cancel remeasuring the fonts when the theme changes
  • TemplateVersionEditorPage
    • The TAR reader has a race condition when the data changes
      • Initialize the file tree for data 1 and kick off an async process for reading it
      • Data changes and kicks off a new effect, and we now do the same thing for data 2
      • Data 2 finishes reading and updates state first because it's shorter
      • Data 1 then finishes and updates state as well, writing stale data
  • WorkspaceBuildProgress
    • Doesn't clear out a timeout

Originally posted by@Parkreiner in#13399 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    siteArea: frontend dashboard

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp