- Notifications
You must be signed in to change notification settings - Fork926
Closed
Description
coderd_oauth2_external_requests_rate_limit_total
andcoderd_api_workspace_latest_build_total
are both gauges, but use the_total
suffix which is usually used to indicate a counter, as described by the prometheusdocumentation on naming.
While this is not strictly a problem, it may lead to users incorrectly assuming they can perform aggregations on these metrics rather than just using their current value; aggregations such asrate
on gauges make no sense.
I'd suggest that we deprecate these metric names, export another metric without the_total
suffix alongside them, and mark the original metrics for removal in the next major release.IMHO metrics are part of the API surface, and therefore should be treated in a semver-observant manner.