Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Deprecate gauge metrics named like counters #12744

Closed
Assignees
snark87
Labels
good first issueEasily solved issues suitable for starters and community contributors
@dannykopping

Description

@dannykopping

coderd_oauth2_external_requests_rate_limit_total andcoderd_api_workspace_latest_build_total are both gauges, but use the_total suffix which is usually used to indicate a counter, as described by the prometheusdocumentation on naming.

While this is not strictly a problem, it may lead to users incorrectly assuming they can perform aggregations on these metrics rather than just using their current value; aggregations such asrate on gauges make no sense.

I'd suggest that we deprecate these metric names, export another metric without the_total suffix alongside them, and mark the original metrics for removal in the next major release.IMHO metrics are part of the API surface, and therefore should be treated in a semver-observant manner.

Metadata

Metadata

Assignees

Labels

good first issueEasily solved issues suitable for starters and community contributors

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions


    [8]ページ先頭

    ©2009-2025 Movatter.jp