- Notifications
You must be signed in to change notification settings - Fork1k
Closed
Assignees
Description
Customers are seeing logs dropped from this line:
coder/enterprise/tailnet/pgcoord.go
Line 190 in83e1349
| c.logger.Critical(c.ctx,"failed to convert node",slog.F("node",bestN),slog.Error(err)) |
like
2023-12-19 02:01:06.578 [crit] coderd.pgcoord: failed to convert node coordinator_id=b830df01-161b-49ca-9003-9b4b23d0e50f node=<nil> error="missing/incorrect type prefix np"We are missing a check for the node being missing (allowed by this function) before trying to convert it.
Since the correct behavior is to return nil (and NOT drop a log), the only problem is the log itself.