- Notifications
You must be signed in to change notification settings - Fork928
Closed
Description
Apparently if both peers are on the same net with no endpoints they can still just end up connecting directly.
Seen here:https://github.com/coder/coder/actions/runs/6931328284/job/18852836455?pr=10790
Error:
run_test.go:436: Error Trace:/Users/runner/work/coder/coder/scaletest/createworkspaces/run_test.go:436 Error: Received unexpected error: run workspace connections in parallel: github.com/coder/coder/v2/scaletest/createworkspaces.(*Runner).Run /Users/runner/work/coder/coder/scaletest/createworkspaces/run.go:172 - run agent connection: github.com/coder/coder/v2/scaletest/createworkspaces.(*Runner).Run.func2 /Users/runner/work/coder/coder/scaletest/createworkspaces/run.go:163 - check connection mode: peer is connected directly, not via DERP: github.com/coder/coder/v2/scaletest/agentconn.(*Runner).Run /Users/runner/work/coder/coder/scaletest/agentconn/run.go:96 Test: Test_Runner/NoCleanup
https://github.com/coder/coder/blob/main/scaletest/agentconn/run.go#L96
// Ensure DERP for completeness.if r.cfg.ConnectionMode == ConnectionModeDerp {status := conn.Status()if len(status.Peers()) != 1 {return xerrors.Errorf("check connection mode: expected 1 peer, got %d", len(status.Peers()))}peer := status.Peer[status.Peers()[0]]if peer.Relay == "" || peer.CurAddr != "" {return xerrors.Errorf("check connection mode: peer is connected directly, not via DERP")}}
Metadata
Metadata
Assignees
Labels
No labels