- Notifications
You must be signed in to change notification settings - Fork1k
Comparing changes
Open a pull request
base repository:coder/coder
Uh oh!
There was an error while loading.Please reload this page.
base:v2.24.2
head repository:coder/coder
Uh oh!
There was an error while loading.Please reload this page.
compare:v2.24.3
- 9commits
- 32files changed
- 10contributors
Commits on Jul 16, 2025
Commits on Aug 5, 2025
chore: add openai icon (cherry-pick#19118) (#19175)
Co-authored-by: ケイラ <mckayla@hey.com>Co-authored-by: 35C4n0r <70096901+35C4n0r@users.noreply.github.com>
Commits on Aug 6, 2025
chore: cherry-pick coder desktop + corporate vpn fixes for 2.24 (#19177)
This backports the coder/coder fixes forcoder/coder-desktop-windows#147 andcoder/coder-desktop-macos#201 to v2.24, andfixes a bug where Coder Desktop logs were duplicated on Windows.1.#19124(`c64b3c0d8327edbfad4cc7bc373bdb873cd7e26b`) - Required for CI to pass.2.#19125(`9f2dc72d9a3d9feecf28bc30cd1234394a0e5c37`) - Required for CI to pass.3.#19143(`914daac2dcf700817d4ae248a6e8014f64654fe7`) - Required for CI to pass.4.#19023(`618121cba39833db7c1ca4653d7ce7745d5aff57`)- First implementation of fix forcoder/coder-desktop-windows#1475.#19069(`ba0b124a1daaddde590f5839afebe803330981be`)- Partially reverts previous commit, actual fix forcoder/coder-desktop-windows#1476.#19052(`19171e27c9624c435f97d4ae5e3b61c649bc7063`) - Avoid duplicating logs on Coder Desktop Windows7.#19080(`18b037d0086cd6eca11e6180b36a302badaa5a5f`)- Updates coder/tailscale reference, lets Coder Desktop macOS use theslim binary to run Coder Connect. I've tested my latest build of Coder Desktop against a Coder serverrunning this branch, just as a sanity check.---------Co-authored-by: Cian Johnston <cian@coder.com>Co-authored-by: Dean Sheather <dean@deansheather.com>
Commits on Aug 7, 2025
fix: pin Nix version to 2.28.4 to avoid JSON type error (#19223)
Pin Nix version to 2.28.4 in dogfood workflowPins the Nix version in the dogfood workflow to 2.28.4 to avoid a JSONtype error that occurs with Nix 2.29 and above.Change-Id: Ie024d5070dbe5901952fc52463c6602363ef8886Signed-off-by: Thomas Kosiewski [tk@coder.com](mailto:tk@coder.com)Signed-off-by: Thomas Kosiewski <tk@coder.com>
fix: upgrade to 1.24.6 to fix race in lib/pq queries (#19214) (#19219)
THIS IS A SECURITY FIX - cherry-picks#19214 upgrade to go 1.24.6 to avoidgolang/go#74831(CVE-2025-47907)Also points to a new version of our lib/pq fork that worked around theGo issue, which should restore better performance.
chore(coderd/database): optimize AuditLogs queries (cherry-pick#18600)…
… (#19193)A customer who recently upgraded their deployment to 2.24 is seeingtheir audit log queries take longer than a minute to load (resulting ina gateway timeout). As such, Support's requested we backport this fix to2.24 (in the next patch), as it does not require a database migration.### Original PR Description (#18600):Closes#17689This PR optimizes the audit logs query performance by extracting thecount operation into a separate query and replacing the OR-basedworkspace_builds with conditional joins.## Query changes* Extracted count query to separate one* Replaced single `workspace_builds` join with OR conditions withseparate conditional joins* Added conditional joins* `wb_build` for workspace_build audit logs (which is a direct lookup) * `wb_workspace` for workspace create audit logs (via workspace)Optimized AuditLogsOffset query:https://explain.dalibo.com/plan/4g1hbedg4a564bg8New CountAuditLogs query:https://explain.dalibo.com/plan/ga2fbcecb9efbce3Co-authored-by: Kacper Sawicki <kacper@coder.com>
fix: use system context for querying workspaces when deleting users (#…
…19211) (#19227)Backport of#19211 to our ESR, v2.24, since this is a kind of bad(albeit rare) bug and very easy to fix.### Original PRCloses#19209.In `templates.go`, we do this to make sure we count ALL workspaces for atemplate before we try and delete that template:https://github.com/coder/coder/blob/dc598856e3be0926573dbbe2ec680e95a139093a/coderd/templates.go#L81-L99However, we weren't doing the same when attempting to delete users,leading to the linked issue. We can solve the issue the same way as wedo for templates.
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v2.24.2...v2.24.3
Uh oh!
There was an error while loading.Please reload this page.