Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitfed70bd

Browse files
authored
fix(helm/coder): set serviceAccount.disableCreate=false by default, add tests (#15197)
* Sets `serviceaccount.disableCreate=false` by default (accidentallychanged by#14817)* Reverts changes made in#15196
1 parent0fba291 commitfed70bd

20 files changed

+399
-16
lines changed

‎.github/workflows/ci.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ jobs:
9090
- "coderd/**"
9191
- "enterprise/**"
9292
- "examples/*"
93+
- "helm/**"
9394
- "provisioner/**"
9495
- "provisionerd/**"
9596
- "provisionersdk/**"

‎helm/coder/tests/chart_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ var testCases = []testCase{
8888
name:"sa_extra_rules",
8989
expectedError:"",
9090
},
91+
{
92+
name:"sa_disabled",
93+
expectedError:"",
94+
},
9195
}
9296

9397
typetestCasestruct {

‎helm/coder/tests/testdata/auto_access_url_1.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/auto_access_url_2.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/auto_access_url_3.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/command.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/command_args.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/default_values.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/env_from.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/extra_templates.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/extra-templates.yaml
317
apiVersion: v1
418
kind: ConfigMap
@@ -92,7 +106,6 @@ spec:
92106
app.kubernetes.io/instance: release-name
93107
---
94108
# Source: coder/templates/coder.yaml
95-
---
96109
apiVersion: apps/v1
97110
kind: Deployment
98111
metadata:

‎helm/coder/tests/testdata/labels_annotations.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/prometheus.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -84,7 +98,6 @@ spec:
8498
app.kubernetes.io/instance: release-name
8599
---
86100
# Source: coder/templates/coder.yaml
87-
---
88101
apiVersion: apps/v1
89102
kind: Deployment
90103
metadata:

‎helm/coder/tests/testdata/provisionerd_psk.golden

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations: {}
7+
labels:
8+
app.kubernetes.io/instance: release-name
9+
app.kubernetes.io/managed-by: Helm
10+
app.kubernetes.io/name: coder
11+
app.kubernetes.io/part-of: coder
12+
app.kubernetes.io/version: 0.1.0
13+
helm.sh/chart: coder-0.1.0
14+
name: coder
15+
---
216
# Source: coder/templates/rbac.yaml
317
apiVersion: rbac.authorization.k8s.io/v1
418
kind: Role
@@ -83,7 +97,6 @@ spec:
8397
app.kubernetes.io/instance: release-name
8498
---
8599
# Source: coder/templates/coder.yaml
86-
---
87100
apiVersion: apps/v1
88101
kind: Deployment
89102
metadata:

‎helm/coder/tests/testdata/sa.golden

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
11
---
2+
# Source: coder/templates/coder.yaml
3+
apiVersion: v1
4+
kind: ServiceAccount
5+
metadata:
6+
annotations:
7+
eks.amazonaws.com/role-arn: arn:aws:iam::123456789012:role/coder-service-account
8+
labels:
9+
app.kubernetes.io/instance: release-name
10+
app.kubernetes.io/managed-by: Helm
11+
app.kubernetes.io/name: coder
12+
app.kubernetes.io/part-of: coder
13+
app.kubernetes.io/version: 0.1.0
14+
helm.sh/chart: coder-0.1.0
15+
name: coder-service-account
16+
---
217
# Source: coder/templates/rbac.yaml
318
apiVersion: rbac.authorization.k8s.io/v1
419
kind: Role
@@ -83,7 +98,6 @@ spec:
8398
app.kubernetes.io/instance: release-name
8499
---
85100
# Source: coder/templates/coder.yaml
86-
---
87101
apiVersion: apps/v1
88102
kind: Deployment
89103
metadata:

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp