Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitfecb90d

Browse files
committed
fix: convert workspace id in db2sdk.WorkspaceAppStatus
This was causing no status to be rendered in the list,and `latest_app_status` to always be nil.
1 parent583a0c6 commitfecb90d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

‎coderd/database/db2sdk/db2sdk.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ func WorkspaceAppStatus(status database.WorkspaceAppStatus) codersdk.WorkspaceAp
539539
return codersdk.WorkspaceAppStatus{
540540
ID:status.ID,
541541
CreatedAt:status.CreatedAt,
542+
WorkspaceID:status.WorkspaceID,
542543
AgentID:status.AgentID,
543544
AppID:status.AppID,
544545
NeedsUserAttention:status.NeedsUserAttention,

‎site/src/pages/WorkspacePage/AppStatuses.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import AppsIcon from "@mui/icons-material/Apps";
44
importCheckCirclefrom"@mui/icons-material/CheckCircle";
55
importErrorIconfrom"@mui/icons-material/Error";
66
importHelpOutlinefrom"@mui/icons-material/HelpOutline";
7+
importHourglassEmptyfrom"@mui/icons-material/HourglassEmpty";
78
importInsertDriveFilefrom"@mui/icons-material/InsertDriveFile";
89
importOpenInNewfrom"@mui/icons-material/OpenInNew";
910
importWarningfrom"@mui/icons-material/Warning";
@@ -18,7 +19,6 @@ import type {
1819
}from"api/typesGenerated";
1920
import{useProxy}from"contexts/ProxyContext";
2021
import{formatDistance,formatDistanceToNow}from"date-fns";
21-
import{DividerWithText}from"pages/DeploymentSettingsPage/LicensesSettingsPage/DividerWithText";
2222
importtype{FC}from"react";
2323
import{createAppLinkHref}from"utils/apps";
2424

@@ -54,7 +54,12 @@ const getStatusIcon = (
5454
case"failure":
5555
return<ErrorIconsx={{ color,fontSize:18}}/>;
5656
case"working":
57-
return<CircularProgresssize={18}sx={{ color}}/>;
57+
// Use Hourglass for past "working" states, spinner for the current one
58+
returnisLatest ?(
59+
<CircularProgresssize={18}sx={{ color}}/>
60+
) :(
61+
<HourglassEmptysx={{ color,fontSize:18}}/>
62+
);
5863
default:
5964
return<Warningsx={{ color,fontSize:18}}/>;
6065
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp