Commitfe733af

authored

chore: fix flake on useAgentLogs (#17919)

We need to wait for the result since the result is depending on effects.Fixcoder/internal#644

1 parent433f0be commitfe733afCopy full SHA for fe733af

File tree

+10

-4

lines changed

+10

-4

lines changed

Lines changed: 10 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import{renderHook}from"@testing-library/react";`
	`1`	`+import{renderHook,waitFor}from"@testing-library/react";`
`2`	`2`	`importtype{WorkspaceAgentLog}from"api/typesGenerated";`
`3`	`3`	`importWSfrom"jest-websocket-mock";`
`4`	`4`	`import{MockWorkspaceAgent}from"testHelpers/entities";`
`@@ -29,17 +29,23 @@ describe("useAgentLogs", () => {`
`29`	`29`
`30`	`30`	`// Send 3 logs`
`31`	`31`	`server.send(JSON.stringify(generateLogs(3)));`
`32`		`-expect(result.current).toHaveLength(3);`
	`32`	`+awaitwaitFor(()=>{`
	`33`	`+expect(result.current).toHaveLength(3);`
	`34`	`+});`
`33`	`35`
`34`	`36`	`// Disable the hook`
`35`	`37`	`rerender({enabled:false});`
`36`		`-expect(result.current).toHaveLength(0);`
	`38`	`+awaitwaitFor(()=>{`
	`39`	`+expect(result.current).toHaveLength(0);`
	`40`	`+});`
`37`	`41`
`38`	`42`	`// Enable the hook again`
`39`	`43`	`rerender({enabled:true});`
`40`	`44`	`awaitserver.connected;`
`41`	`45`	`server.send(JSON.stringify(generateLogs(3)));`
`42`		`-expect(result.current).toHaveLength(3);`
	`46`	`+awaitwaitFor(()=>{`
	`47`	`+expect(result.current).toHaveLength(3);`
	`48`	`+});`
`43`	`49`	`});`
`44`	`50`	`});`
`45`	`51`

Comments

(0)