Commitfda71da

authored

fix: Copy replicas to prevent race (#4596)

1 parent618c6dc commitfda71daCopy full SHA for fda71da

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,14 @@ func (m *Manager) Self() database.Replica {`
`315`	`315`	`func (m*Manager)All() []database.Replica {`
`316`	`316`	`m.mutex.Lock()`
`317`	`317`	`deferm.mutex.Unlock()`
`318`		`-returnappend(m.peers[:],m.self)`
	`318`	`+replicas:=make([]database.Replica,0,len(m.peers))`
	`319`	`+for_,replica:=rangeappend(m.peers,m.self) {`
	`320`	`+// When we assign the non-pointer to a`
	`321`	`+// variable it loses the reference.`
	`322`	`+replica:=replica`
	`323`	`+replicas=append(replicas,replica)`
	`324`	`+}`
	`325`	`+returnreplicas`
`319`	`326`	`}`
`320`	`327`
`321`	`328`	`// Regional returns all replicas in the same region excluding itself.`

Comments

(0)