NotificationsYou must be signed in to change notification settings
Fork905
Star10k

Commitfd6981e

authored

fix: fix flashing error dialog in the create workspace page (#18180)

This PR which updated react-query to 5.77.0 introduced an issue on thecreate workspace page where the error dialog would be briefly displayedwhile the page is loading.#18039The issue is that there is a moment when `optOutQuery.isLoading` isfalse and `optOutQuery.data` is undefined causing the ErrorAlert todisplay.

1 parent1d27d4f commitfd6981eCopy full SHA for fd6981e

File tree

1 file changed

-3

lines changed

site/src/pages/CreateWorkspacePage
- CreateWorkspaceExperimentRouter.tsx

1 file changed

-3

lines changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,11 @@ const CreateWorkspaceExperimentRouter: FC = () => {`
`44`	`44`	`});`
`45`	`45`
`46`	`46`	`if(dynamicParametersEnabled){`
`47`		`-if(optOutQuery.isLoading){`
`48`		`-return<Loader/>;`
	`47`	`+if(optOutQuery.isError){`
	`48`	`+return<ErrorAlerterror={optOutQuery.error}/>;`
`49`	`49`	`}`
`50`	`50`	`if(!optOutQuery.data){`
`51`		`-return<ErrorAlerterror={optOutQuery.error}/>;`
	`51`	`+return<Loader/>;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`consttoggleOptedOut=()=>{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfd6981e

File tree

1 file changed

1 file changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx`

0 commit comments