NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commitfd376ad

committed

s/readAllUsers/viewAllUsers

Seems like all the other frontend variables use the `view` syntax.Arguably we should use `read` to match the backend, but `view` does seemmore UI-like.

1 parentbf4b7ab commitfd376adCopy full SHA for fd376ad

File tree

3 files changed

-4

lines changed

site/src
- contexts/auth
  - permissions.tsx
- modules/dashboard/Navbar
  - Navbar.tsx
- testHelpers
  - entities.ts

3 files changed

-4

lines changed

`‎site/src/contexts/auth/permissions.tsx`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`exportconstchecks={`
`2`		`-readAllUsers:"readAllUsers",`
	`2`	`+viewAllUsers:"viewAllUsers",`
`3`	`3`	`updateUsers:"updateUsers",`
`4`	`4`	`createUser:"createUser",`
`5`	`5`	`createTemplates:"createTemplates",`
`@@ -15,7 +15,7 @@ export const checks = {`
`15`	`15`	`}asconst;`
`16`	`16`
`17`	`17`	`exportconstpermissionsToCheck={`
`18`		`-[checks.readAllUsers]:{`
	`18`	`+[checks.viewAllUsers]:{`
`19`	`19`	`object:{`
`20`	`20`	`resource_type:"user",`
`21`	`21`	`},`

`‎site/src/modules/dashboard/Navbar/Navbar.tsx`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const Navbar: FC = () => {`
`21`	`21`	`constcanViewOrganizations=`
`22`	`22`	`featureVisibility.multiple_organizations&&`
`23`	`23`	`experiments.includes("multi-organization");`
`24`		`-constcanViewAllUsers=Boolean(permissions.readAllUsers);`
	`24`	`+constcanViewAllUsers=Boolean(permissions.viewAllUsers);`
`25`	`25`	`constproxyContextValue=useProxy();`
`26`	`26`	`constcanViewHealth=canViewDeployment;`
`27`	`27`

`‎site/src/testHelpers/entities.ts`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2477,7 +2477,7 @@ export const MockPermissions: Permissions = {`
`2477`	`2477`	`createUser:true,`
`2478`	`2478`	`deleteTemplates:true,`
`2479`	`2479`	`updateTemplates:true,`
`2480`		`-readAllUsers:true,`
	`2480`	`+viewAllUsers:true,`
`2481`	`2481`	`updateUsers:true,`
`2482`	`2482`	`viewAuditLog:true,`
`2483`	`2483`	`viewDeploymentValues:true,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfd376ad

File tree

3 files changed

3 files changed

`‎site/src/contexts/auth/permissions.tsx`

`‎site/src/modules/dashboard/Navbar/Navbar.tsx`

`‎site/src/testHelpers/entities.ts`

0 commit comments