Commitfd0f8a3

committed

make lifecycle executor spawn a new goroutine automatically

1 parentf6388b4 commitfd0f8a3Copy full SHA for fd0f8a3

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ func server() *cobra.Command {`
`347`	`347`	`lifecyclePoller:=time.NewTicker(time.Minute)`
`348`	`348`	`deferlifecyclePoller.Stop()`
`349`	`349`	`lifecycleExecutor:=executor.New(cmd.Context(),options.Database,logger,lifecyclePoller.C)`
`350`		`-golifecycleExecutor.Run()`
	`350`	`+lifecycleExecutor.Run()`
`351`	`351`
`352`	`352`	`// Because the graceful shutdown includes cleaning up workspaces in dev mode, we're`
`353`	`353`	`// going to make it harder to accidentally skip the graceful shutdown by hitting ctrl+c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ func New(t testing.T, options Options) *codersdk.Client {`
`110`	`110`	`slogtest.Make(t,nil).Named("lifecycle.executor").Leveled(slog.LevelDebug),`
`111`	`111`	`options.LifecycleTicker,`
`112`	`112`	`)`
`113`		`-golifecycleExecutor.Run()`
	`113`	`+lifecycleExecutor.Run()`
`114`	`114`
`115`	`115`	`srv:=httptest.NewUnstartedServer(nil)`
`116`	`116`	`srv.Config.BaseContext=func(_ net.Listener) context.Context {`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,13 @@ func New(ctx context.Context, db database.Store, log slog.Logger, tick <-chan ti`
`38`	`38`	`// tick from its channel. It will stop when its context is Done, or when`
`39`	`39`	`// its channel is closed.`
`40`	`40`	`func (e*Executor)Run() {`
`41`		`-fort:=rangee.tick {`
`42`		`-iferr:=e.runOnce(t);err!=nil {`
`43`		`-e.log.Error(e.ctx,"error running once",slog.Error(err))`
	`41`	`+gofunc() {`
	`42`	`+fort:=rangee.tick {`
	`43`	`+iferr:=e.runOnce(t);err!=nil {`
	`44`	`+e.log.Error(e.ctx,"error running once",slog.Error(err))`
	`45`	`+}`
`44`	`46`	`}`
`45`		`-}`
	`47`	`+}()`
`46`	`48`	`}`
`47`	`49`
`48`	`50`	`func (e*Executor)runOnce(t time.Time)error {`

Comments

(0)