NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commitfade8ba

authored

fix: fix MeasureLatencyRecvTimeout to accept send=0 (#13477)

Fixes the flake seen here:https://github.com/coder/coder/runs/25832852690Linux is not a real time operating system, and so there is no guarantee that subsequent `time.Now()` `time.Since()` calls will return a non-zero time. This assert is mainly there to ensure we don't return `-1`.

1 parent775fc3f commitfade8baCopy full SHA for fade8ba

File tree

1 file changed

-1

lines changed

coderd/database/pubsub
- pubsub_linux_test.go

1 file changed

-1

lines changed

`‎coderd/database/pubsub/pubsub_linux_test.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ func TestMeasureLatency(t *testing.T) {`
`351`	`351`
`352`	`352`	`send,recv,err:=pubsub.NewLatencyMeasurer(logger).Measure(ctx,ps)`
`353`	`353`	`require.ErrorContains(t,err,context.Canceled.Error())`
`354`		`-require.Greater(t,send.Nanoseconds(),int64(0))`
	`354`	`+require.GreaterOrEqual(t,send.Nanoseconds(),int64(0))`
`355`	`355`	`require.EqualValues(t,recv,time.Duration(-1))`
`356`	`356`	`})`
`357`	`357`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfade8ba

File tree

1 file changed

1 file changed

`‎coderd/database/pubsub/pubsub_linux_test.go`

0 commit comments