Commitf735b69

committed

best-effort fix but testing dbmem sort order is a waste of time

1 parentff3cde2 commitf735b69Copy full SHA for f735b69

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7738,12 +7738,9 @@ func (q *FakeQuerier) GetAuthorizedWorkspaces(ctx context.Context, arg database.`
`7738`	`7738`	`w2:=workspaces[j]`
`7739`	`7739`
`7740`	`7740`	`// Order by: favorite first`
`7741`		`-ifw1.FavoriteOf.Valid&&!w2.FavoriteOf.Valid {`
	`7741`	`+ifw1.FavoriteOf==arg.OrderByFavorite {`
`7742`	`7742`	`returntrue`
`7743`	`7743`	`}`
`7744`		`-if!w1.FavoriteOf.Valid&&w2.FavoriteOf.Valid {`
`7745`		`-returnfalse`
`7746`		`-}`
`7747`	`7744`
`7748`	`7745`	`// Order by: running`
`7749`	`7746`	`w1IsRunning:=isRunning(preloadedWorkspaceBuilds[w1.ID],preloadedProvisionerJobs[w1.ID])`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -479,6 +479,10 @@ func TestAdminViewAllWorkspaces(t *testing.T) {`
`479`	`479`	`funcTestWorkspacesSortOrder(t*testing.T) {`
`480`	`480`	`t.Parallel()`
`481`	`481`
	`482`	`+if!dbtestutil.WillUsePostgres() {`
	`483`	`+t.Skip("sort order is only tested on postgres")`
	`484`	`+}`
	`485`	`+`
`482`	`486`	`client,db:=coderdtest.NewWithDatabase(t,nil)`
`483`	`487`	`firstUser:=coderdtest.CreateFirstUser(t,client)`
`484`	`488`	`secondUserClient,secondUser:=coderdtest.CreateAnotherUserMutators(t,client,firstUser.OrganizationID, []string{"owner"},func(r*codersdk.CreateUserRequest) {`

Comments

(0)