Commitf66e802

authored

fix(coderd/debug): putDeploymentHealthSettings: use 204 instead of 304 if not modified (#11048)

1 parent876d448 commitf66e802Copy full SHA for f66e802

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,8 @@ func (api API) putDeploymentHealthSettings(rw http.ResponseWriter, r http.Requ`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`ifbytes.Equal(settingsJSON, []byte(currentSettingsJSON)) {`
`208`		`-httpapi.Write(r.Context(),rw,http.StatusNotModified,nil)`
	`208`	`+// See: https://www.rfc-editor.org/rfc/rfc7231#section-6.3.5`
	`209`	`+httpapi.Write(r.Context(),rw,http.StatusNoContent,nil)`
`209`	`210`	`return`
`210`	`211`	`}`
`211`	`212`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func (c *Client) PutHealthSettings(ctx context.Context, settings HealthSettings)`
`36`	`36`	`}`
`37`	`37`	`deferres.Body.Close()`
`38`	`38`
`39`		`-ifres.StatusCode==http.StatusNotModified {`
	`39`	`+ifres.StatusCode==http.StatusNoContent {`
`40`	`40`	`returnxerrors.New("health settings not modified")`
`41`	`41`	`}`
`42`	`42`	`ifres.StatusCode!=http.StatusOK {`

Comments

(0)