Commitf5dbc71

authored

fix: accept agent RPC connection without version query parameter (#11790)

Fixes an issue where Coder v2.7.1 agents connect to /api/v2/workspaceagents/me/rpc without a version query parameter

1 parent13beb04 commitf5dbc71Copy full SHA for f5dbc71

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,10 +40,10 @@ func (api API) workspaceAgentRPC(rw http.ResponseWriter, r http.Request) {`
`40`	`40`
`41`	`41`	`version:=r.URL.Query().Get("version")`
`42`	`42`	`ifversion=="" {`
`43`		`-httpapi.Write(ctx,rw,http.StatusBadRequest, codersdk.Response{`
`44`		`-Message:"Missing required query parameter:version",`
`45`		`-})`
`46`		`-return`
	`43`	`+// The initial version on this HTTP endpoint was 2.0, so assume this version if unspecified.`
	`44`	`+// Coder v2.7.1 (not to be confused with the Agent APIversion) calls this endpoint without`
	`45`	`+// a version parameter and wants Agent API version 2.0.`
	`46`	`+version="2.0"`
`47`	`47`	`}`
`48`	`48`	`iferr:=proto.CurrentVersion.Validate(version);err!=nil {`
`49`	`49`	`httpapi.Write(ctx,rw,http.StatusBadRequest, codersdk.Response{`

Comments

(0)