Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitf3bbf62

Browse files
authored
chore: Update gotestsum to v1.9.0 and remove debugging (#5726)
* chore: Update gotestsum to v1.9.0 and remove debugging* chore: Update cloud.google.gpg to fix dogfood build
1 parent1d777c4 commitf3bbf62

File tree

4 files changed

+5
-51
lines changed

4 files changed

+5
-51
lines changed

‎.github/workflows/coder.yaml‎

Lines changed: 3 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ jobs:
320320
GITHUB_TOKEN:${{ secrets.GITHUB_TOKEN }}
321321
with:
322322
repo:gotestyourself/gotestsum
323-
tag:v1.8.2
323+
tag:v1.9.0
324324

325325
-uses:hashicorp/setup-terraform@v2
326326
with:
@@ -340,30 +340,8 @@ jobs:
340340
else
341341
echo ::set-output name=cover::false
342342
fi
343-
set +e
344-
gotestsum --junitfile="gotests.xml" --jsonfile="gotestsum.json" --packages="./..." --debug -- -parallel=8 -timeout=5m -short -failfast $COVERAGE_FLAGS
345-
ret=$?
346-
if ((ret)); then
347-
# Eternalize test timeout logs because "re-run failed" erases
348-
# artifacts and gotestsum doesn't always capture it:
349-
# https://github.com/gotestyourself/gotestsum/issues/292
350-
# Multiple test packages could've failed, each one may or may
351-
# not run into the edge case. PS. Don't summon ShellCheck here.
352-
for testWithStack in $(grep 'panic: test timed out' gotestsum.json | grep -E -o '("Test":[^,}]*)'); do
353-
if [ -n "$testWithStack" ] && grep -q "${testWithStack}.*PASS" gotestsum.json; then
354-
echo "Conditions met for gotestsum stack trace missing bug, outputting panic trace:"
355-
grep -A 999999 "${testWithStack}.*panic: test timed out" gotestsum.json
356-
fi
357-
done
358-
fi
359-
exit $ret
360343
361-
-uses:actions/upload-artifact@v3
362-
if:success() || failure()
363-
with:
364-
name:gotestsum-debug-${{ matrix.os }}.json
365-
path:./gotestsum.json
366-
retention-days:7
344+
gotestsum --junitfile="gotests.xml" --packages="./..." -- -parallel=8 -timeout=5m -short -failfast $COVERAGE_FLAGS
367345
368346
-uses:actions/upload-artifact@v3
369347
if:success() || failure()
@@ -423,7 +401,7 @@ jobs:
423401
GITHUB_TOKEN:${{ secrets.GITHUB_TOKEN }}
424402
with:
425403
repo:gotestyourself/gotestsum
426-
tag:v1.8.2
404+
tag:v1.9.0
427405

428406
-uses:hashicorp/setup-terraform@v2
429407
with:
@@ -432,30 +410,7 @@ jobs:
432410

433411
-name:Test with PostgreSQL Database
434412
run:|
435-
set +e
436413
make test-postgres
437-
ret=$?
438-
if ((ret)); then
439-
# Eternalize test timeout logs because "re-run failed" erases
440-
# artifacts and gotestsum doesn't always capture it:
441-
# https://github.com/gotestyourself/gotestsum/issues/292
442-
# Multiple test packages could've failed, each one may or may
443-
# not run into the edge case. PS. Don't summon ShellCheck here.
444-
for testWithStack in $(grep 'panic: test timed out' gotestsum.json | grep -E -o '("Test":[^,}]*)'); do
445-
if [ -n "$testWithStack" ] && grep -q "${testWithStack}.*PASS" gotestsum.json; then
446-
echo "Conditions met for gotestsum stack trace missing bug, outputting panic trace:"
447-
grep -A 999999 "${testWithStack}.*panic: test timed out" gotestsum.json
448-
fi
449-
done
450-
fi
451-
exit $ret
452-
453-
-uses:actions/upload-artifact@v3
454-
if:success() || failure()
455-
with:
456-
name:gotestsum-debug-postgres.json
457-
path:./gotestsum.json
458-
retention-days:7
459414
460415
-uses:actions/upload-artifact@v3
461416
if:success() || failure()

‎Makefile‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,7 @@ site/.eslintignore site/.prettierignore: .prettierignore Makefile
556556
done<"$<"
557557

558558
test: test-clean
559-
gotestsum --debug -- -v -short ./...
559+
gotestsum -- -v -short ./...
560560
.PHONY: test
561561

562562
# When updating -timeout for this test, keep in sync with
@@ -566,7 +566,6 @@ test-postgres: test-clean test-postgres-docker
566566
# more consistent execution.
567567
DB=ci DB_FROM=$(shell go run scripts/migrate-ci/main.go) gotestsum\
568568
--junitfile="gotests.xml"\
569-
--jsonfile="gotestsum.json"\
570569
--packages="./..." --\
571570
-covermode=atomic -coverprofile="gotests.coverage" -timeout=20m\
572571
-parallel=4\

‎dogfood/Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ RUN mkdir --parents "$GOPATH" && \
4343
# the language server protocol
4444
go install golang.org/x/tools/gopls@latest && \
4545
# gotestsum makes test output more readable
46-
go install gotest.tools/gotestsum@v1.7.0 && \
46+
go install gotest.tools/gotestsum@v1.9.0 && \
4747
# goveralls collects code coverage metrics from tests
4848
# and sends to Coveralls
4949
go install github.com/mattn/goveralls@v0.0.11 && \
-1.3 KB
Binary file not shown.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp