Commitf0132b5

authored

fix: fix workspace proxy command app link href (#11423)

* fix: workspace proxy command app link href

1 parent46b90ce commitf0132b5Copy full SHA for f0132b5

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ describe("create app link", () => {`
`59`	`59`	`},`
`60`	`60`	`);`
`61`	`61`	`expect(href).toBe(`
`62`		`-"/path-base/@username/Test-Workspace.a-workspace-agent/terminal?command=ls%20-la",`
	`62`	`+"/@username/Test-Workspace.a-workspace-agent/terminal?command=ls%20-la",`
`63`	`63`	`);`
`64`	`64`	`});`
`65`	`65`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,10 @@ export const createAppLinkHref = (`
`20`	`20`	`agent.name`
`21`	`21`	}/apps/${encodeURIComponent(appSlug)}/`;
`22`	`22`	`if(app.command){`
`23`		-href=`${preferredPathBase}/@${username}/${workspace.name}.${
	`23`	`+// Terminal links are relative. The terminal page knows how`
	`24`	`+// to select the correct workspace proxy for the websocket`
	`25`	`+// connection.`
	`26`	+href=`/@${username}/${workspace.name}.${
`24`	`27`	`agent.name`
`25`	`28`	}/terminal?command=${encodeURIComponent(app.command)}`;
`26`	`29`	`}`

Comments

(0)