Commitefa69a8

committed

fix: iterate through all workspace updates on logs overflow

This was causing some flakes!

1 parent6378294 commitefa69a8Copy full SHA for efa69a8

File tree

+13

-7

lines changed

+13

-7

lines changed

Lines changed: 13 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -282,14 +282,20 @@ func TestWorkspaceAgentStartupLogs(t *testing.T) {`
`282`	`282`	`require.ErrorAs(t,err,&apiError)`
`283`	`283`	`require.Equal(t,http.StatusRequestEntityTooLarge,apiError.StatusCode())`
`284`	`284`
`285`		`-varupdate codersdk.Workspace`
`286`		`-select {`
`287`		`-case<-ctx.Done():`
`288`		`-t.FailNow()`
`289`		`-caseupdate=<-updates:`
	`285`	`+// It's possible we have multiple updates queued, but that's alright, we just`
	`286`	`+// wait for the one where it overflows.`
	`287`	`+for {`
	`288`	`+varupdate codersdk.Workspace`
	`289`	`+select {`
	`290`	`+case<-ctx.Done():`
	`291`	`+t.FailNow()`
	`292`	`+caseupdate=<-updates:`
	`293`	`+}`
	`294`	`+ifupdate.LatestBuild.Resources[0].Agents[0].StartupLogsOverflowed {`
	`295`	`+break`
	`296`	`+}`
`290`	`297`	`}`
`291`		`-// Ensure that the UI gets an update when the logs overflow!`
`292`		`-require.True(t,update.LatestBuild.Resources[0].Agents[0].StartupLogsOverflowed)`
	`298`	`+`
`293`	`299`	`})`
`294`	`300`	`}`
`295`	`301`

Comments

(0)