Commitec7ab40

committed

Fix notifications visibility

1 parent2ecbe5f commitec7ab40Copy full SHA for ec7ab40

File tree

-5

lines changed

site/src/pages
- DeploySettingsPage
  - Sidebar.tsx
- UserSettingsPage
  - Sidebar.tsx

-5

lines changed

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,11 @@ import {`
`13`	`13`	`SidebarasBaseSidebar,`
`14`	`14`	`SidebarNavItem,`
`15`	`15`	`}from"components/Sidebar/Sidebar";`
	`16`	`+import{useDashboard}from"modules/dashboard/useDashboard";`
`16`	`17`
`17`	`18`	`exportconstSidebar:FC=()=>{`
	`19`	`+const{ experiments}=useDashboard();`
	`20`	`+`
`18`	`21`	`return(`
`19`	`22`	`<BaseSidebar>`
`20`	`23`	`<SidebarNavItemhref="general"icon={LaunchOutlined}>`
`@@ -48,9 +51,11 @@ export const Sidebar: FC = () => {`
`48`	`51`	`<SidebarNavItemhref="observability"icon={InsertChartIcon}>`
`49`	`52`	`Observability`
`50`	`53`	`</SidebarNavItem>`
`51`		`-<SidebarNavItemhref="notifications"icon={NotificationsIcon}>`
`52`		`- Notifications`
`53`		`-</SidebarNavItem>`
	`54`	`+{experiments.includes("notifications")&&(`
	`55`	`+<SidebarNavItemhref="notifications"icon={NotificationsIcon}>`
	`56`	`+ Notifications`
	`57`	`+</SidebarNavItem>`
	`58`	`+)}`
`54`	`59`	`</BaseSidebar>`
`55`	`60`	`);`
`56`	`61`	`};`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ export const Sidebar: FC<SidebarProps> = ({ user }) => {`
`24`	`24`	`const{ entitlements, experiments}=useDashboard();`
`25`	`25`	`constshowSchedulePage=`
`26`	`26`	`entitlements.features.advanced_template_scheduling.enabled;`
`27`		`-constshowNotificationsPage=experiments.includes("notifications");`
`28`	`27`
`29`	`28`	`return(`
`30`	`29`	`<BaseSidebar>`
`@@ -58,7 +57,7 @@ export const Sidebar: FC<SidebarProps> = ({ user }) => {`
`58`	`57`	`<SidebarNavItemhref="tokens"icon={VpnKeyOutlined}>`
`59`	`58`	`Tokens`
`60`	`59`	`</SidebarNavItem>`
`61`		`-{showNotificationsPage&&(`
	`60`	`+{experiments.includes("notifications")&&(`
`62`	`61`	`<SidebarNavItemhref="notifications"icon={NotificationsIcon}>`
`63`	`62`	`Notifications`
`64`	`63`	`</SidebarNavItem>`

Comments

(0)