NotificationsYou must be signed in to change notification settings
Fork911
Star10k

Commitebad5c3

authored

test(agent): fix channel timeout in TestNewServer_CloseActiveConnections (#17690)

This fixes a test issue where we were waiting on a channel indefinitelyand the test timed out instead of failing due to earlier error.Updatescoder/internal#558

1 parentec003b7 commitebad5c3Copy full SHA for ebad5c3

File tree

1 file changed

-1

lines changed

agent/agentssh
- agentssh_test.go

1 file changed

-1

lines changed

`‎agent/agentssh/agentssh_test.go`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,11 @@ func TestNewServer_CloseActiveConnections(t *testing.T) {`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`for_,ch:=rangewaitConns {`
`217`		`-<-ch`
	`217`	`+select {`
	`218`	`+case<-ctx.Done():`
	`219`	`+t.Fatal("timeout")`
	`220`	`+case<-ch:`
	`221`	`+}`
`218`	`222`	`}`
`219`	`223`
`220`	`224`	`returns,wg.Wait`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitebad5c3

File tree

1 file changed

1 file changed

`‎agent/agentssh/agentssh_test.go`

0 commit comments