NotificationsYou must be signed in to change notification settings
Fork907
Star10k

Commite718c3a

authored

fix: improve WebSocket error handling in CreateWorkspacePageExperimental (#17647)

Refactor WebSocket error handling to ensure that errors are only setwhen the current socket ref matches the active one. This preventsunnecessary error messages when the WebSocket connection closesunexpectedlyThis solves the problem of showing error messages because of ReactStrict mode rendering the page twice and opening 2 websocketconnections.

1 parenta226a75 commite718c3aCopy full SHA for e718c3a

File tree

1 file changed

+12

-11

lines changed

site/src/pages/CreateWorkspacePage
- CreateWorkspacePageExperimental.tsx

1 file changed

+12

-11

lines changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx`

Lines changed: 12 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,26 +95,27 @@ const CreateWorkspacePageExperimental: FC = () => {`
`95`	`95`
`96`	`96`	`// Initialize the WebSocket connection when there is a valid template version ID`
`97`	`97`	`useEffect(()=>{`
`98`		`-if(!realizedVersionId){`
`99`		`-return;`
`100`		`-}`
	`98`	`+if(!realizedVersionId)return;`
`101`	`99`
`102`	`100`	`constsocket=API.templateVersionDynamicParameters(`
`103`	`101`	`owner.id,`
`104`	`102`	`realizedVersionId,`
`105`	`103`	`{`
`106`	`104`	`onMessage,`
`107`	`105`	`onError:(error)=>{`
`108`		`-setWsError(error);`
	`106`	`+if(ws.current===socket){`
	`107`	`+setWsError(error);`
	`108`	`+}`
`109`	`109`	`},`
`110`	`110`	`onClose:()=>{`
`111`		`-// There is no reason for the websocket to close while a user is on the page`
`112`		`-setWsError(`
`113`		`-newDetailedError(`
`114`		`-"Websocket connection for dynamic parameters unexpectedly closed.",`
`115`		`-"Refresh the page to reset the form.",`
`116`		`-),`
`117`		`-);`
	`111`	`+if(ws.current===socket){`
	`112`	`+setWsError(`
	`113`	`+newDetailedError(`
	`114`	`+"Websocket connection for dynamic parameters unexpectedly closed.",`
	`115`	`+"Refresh the page to reset the form.",`
	`116`	`+),`
	`117`	`+);`
	`118`	`+}`
`118`	`119`	`},`
`119`	`120`	`},`
`120`	`121`	`);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite718c3a

File tree

1 file changed

1 file changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx`

0 commit comments