Commite6a5499

committed

fix: update isNotificationTextPrefixed

This removes an eslint-disable rule and adds two new tests to ensureisNotificationTextPrefixed is working as expected.

1 parentb23f35f commite6a5499Copy full SHA for e6a5499

File tree

+28

-2

lines changed

+28

-2

lines changed

Lines changed: 24 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import {`
`4`	`4`	`isNotificationTextPrefixed,`
`5`	`5`	`MsgType,`
`6`	`6`	`NotificationMsg,`
	`7`	`+NotificationTextPrefixed,`
`7`	`8`	`SnackbarEventType,`
`8`	`9`	`}from"./utils"`
`9`	`10`
`@@ -17,6 +18,29 @@ describe("Snackbar", () => {`
`17`	`18`	`// When`
`18`	`19`	`constisTextPrefixed=isNotificationTextPrefixed(msg)`
`19`	`20`
	`21`	`+// Then`
	`22`	`+expect(isTextPrefixed).toBe(false)`
	`23`	`+})`
	`24`	`+it("returns true if prefixed",()=>{`
	`25`	`+// Given`
	`26`	`+constmsg:NotificationTextPrefixed={`
	`27`	`+prefix:"warning",`
	`28`	`+text:"careful with this workspace",`
	`29`	`+}`
	`30`	`+`
	`31`	`+// When`
	`32`	`+constisTextPrefixed=isNotificationTextPrefixed(msg)`
	`33`	`+`
	`34`	`+// Then`
	`35`	`+expect(isTextPrefixed).toBe(true)`
	`36`	`+})`
	`37`	`+it("returns false if not prefixed",()=>{`
	`38`	`+// Given`
	`39`	`+constmsg="plain ol' message"`
	`40`	`+`
	`41`	`+// When`
	`42`	`+constisTextPrefixed=isNotificationTextPrefixed(msg)`
	`43`	`+`
`20`	`44`	`// Then`
`21`	`45`	`expect(isTextPrefixed).toBe(false)`
`22`	`46`	`})`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,10 @@ export const isNotificationText = (msg: AdditionalMessage): msg is string => {`
`27`	`27`	`exportconstisNotificationTextPrefixed=(`
`28`	`28`	`msg:AdditionalMessage\|null,`
`29`	`29`	`):msg isNotificationTextPrefixed=>{`
`30`		`-// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition`
`31`		`-returntypeof(msgasNotificationTextPrefixed)?.prefix!=="undefined"`
	`30`	`+if(msg){`
	`31`	`+returntypeofmsg!=="string"&&Object.prototype.hasOwnProperty.call(msg,"prefix")`
	`32`	`+}`
	`33`	`+returnfalse`
`32`	`34`	`}`
`33`	`35`
`34`	`36`	`exportconstisNotificationList=(msg:AdditionalMessage):msg isstring[]=>{`

Comments

(0)