Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite562e3c

Browse files
authored
chore: mark parameters as required (#17551)
This adds a red asterisk next to a parameter name if it is required andmarks passes the parameter required value to input and textarea formcontrols.The multi-select combobox needs additional work (in a separate PR) sothat it can handle the required prop correctly for form submit.<img width="544" alt="Screenshot 2025-04-24 at 00 02 10"src="https://github.com/user-attachments/assets/5c6758d3-41a4-444d-b7e9-e1fe011703d3"/>
1 parentfc921a5 commite562e3c

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

‎site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,12 @@ const ParameterLabel: FC<ParameterLabelProps> = ({ parameter, isPreset }) => {
9595

9696
<divclassName="flex flex-col w-full gap-1">
9797
<LabelclassName="flex gap-2 flex-wrap text-sm font-medium">
98-
{displayName}
99-
98+
<spanclassName="flex">
99+
{displayName}
100+
{!parameter.required&&(
101+
<spanclassName="text-content-destructive">*</span>
102+
)}
103+
</span>
100104
{parameter.mutable&&(
101105
<TooltipProviderdelayDuration={100}>
102106
<Tooltip>
@@ -169,6 +173,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
169173
onValueChange={onChange}
170174
defaultValue={defaultValue}
171175
disabled={disabled}
176+
required={parameter.required}
172177
>
173178
<SelectTrigger>
174179
<SelectValue
@@ -325,6 +330,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
325330
placeholder={
326331
(parameter.stylingas{placeholder?:string})?.placeholder
327332
}
333+
required={parameter.required}
328334
/>
329335
);
330336

@@ -351,6 +357,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
351357
defaultValue={defaultValue}
352358
onChange={(e)=>onChange(e.target.value)}
353359
disabled={disabled}
360+
required={parameter.required}
354361
placeholder={
355362
(parameter.stylingas{placeholder?:string})?.placeholder
356363
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp