NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commite345827

authored

fix: Multiple builds using the incorrect agent token (#983)

This was an issue with our in-memory database that causednewer builds to return an outdated agent, which would thenbe rejected.A test case has been added to ensure this can't happen again!

1 parente8b3101 commite345827Copy full SHA for e345827

File tree

1 file changed

-1

lines changed

coderd/database/databasefake
- databasefake.go

1 file changed

-1

lines changed

`‎coderd/database/databasefake/databasefake.go`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -626,7 +626,9 @@ func (q *fakeQuerier) GetWorkspaceAgentByAuthToken(_ context.Context, authToken`
`626`	`626`	`q.mutex.RLock()`
`627`	`627`	`deferq.mutex.RUnlock()`
`628`	`628`
`629`		`-for_,agent:=rangeq.provisionerJobAgent {`
	`629`	`+// The schema sorts this by created at, so we iterate the array backwards.`
	`630`	`+fori:=len(q.provisionerJobAgent)-1;i>=0;i-- {`
	`631`	`+agent:=q.provisionerJobAgent[i]`
`630`	`632`	`ifagent.AuthToken.String()==authToken.String() {`
`631`	`633`	`returnagent,nil`
`632`	`634`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite345827

File tree

1 file changed

1 file changed

`‎coderd/database/databasefake/databasefake.go`

0 commit comments