Commite0e6d7c

authored

fix: case insensitve agent ssh session env var (#9675)

1 parent0e4d689 commite0e6d7cCopy full SHA for e0e6d7c

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -254,11 +254,13 @@ func (s *Server) sessionStart(session ssh.Session, extraEnv []string) (retErr er`
`254`	`254`	`magicType=strings.TrimPrefix(kv,MagicSessionTypeEnvironmentVariable+"=")`
`255`	`255`	`env=append(env[:index],env[index+1:]...)`
`256`	`256`	`}`
`257`		`-switchmagicType {`
`258`		`-caseMagicSessionTypeVSCode:`
	`257`	`+`
	`258`	`+// Always force lowercase checking to be case-insensitive.`
	`259`	`+switchstrings.ToLower(magicType) {`
	`260`	`+casestrings.ToLower(MagicSessionTypeVSCode):`
`259`	`261`	`s.connCountVSCode.Add(1)`
`260`	`262`	`defers.connCountVSCode.Add(-1)`
`261`		`-caseMagicSessionTypeJetBrains:`
	`263`	`+casestrings.ToLower(MagicSessionTypeJetBrains):`
`262`	`264`	`s.connCountJetBrains.Add(1)`
`263`	`265`	`defers.connCountJetBrains.Add(-1)`
`264`	`266`	`case"":`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,8 @@`
`1`	`1`	`package agentssh`
`2`	`2`
`3`	`3`	`import (`
	`4`	`+"strings"`
	`5`	`+`
`4`	`6`	`"github.com/prometheus/client_golang/prometheus"`
`5`	`7`	`)`
`6`	`8`
`@@ -78,5 +80,6 @@ func magicTypeMetricLabel(magicType string) string {`
`78`	`80`	`default:`
`79`	`81`	`magicType="unknown"`
`80`	`82`	`}`
`81`		`-returnmagicType`
	`83`	`+// Always be case insensitive`
	`84`	`+returnstrings.ToLower(magicType)`
`82`	`85`	`}`

Comments

(0)