Commitdfc353b

authored

fix: Fix storybook blockers (#443)

I was just testing `storybook` out on `main`, and saw some of the components had errors:<img width="1564" alt="image" src="https://user-images.githubusercontent.com/88213859/158444846-773420f5-261a-4853-abe1-66521ed19901.png">There were two problems:- The `<Workspace />` component had new arguments, that don't seem to be validated by `yarn storybook:build`- The top-level `react-router-dom` is not available in storybook. After fixing these, all the storybook components work:<img width="1304" alt="image" src="https://user-images.githubusercontent.com/88213859/158445124-eec51500-967d-4e24-823f-c21f6ea63ba1.png">

1 parent97399f8 commitdfc353bCopy full SHA for dfc353b

File tree

+17

-1

lines changed

site
- .storybook
  - preview.js
- components/Workspace
  - Workspace.stories.tsx

+17

-1

lines changed

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,23 @@ import ThemeProvider from "@material-ui/styles/ThemeProvider"`
`2`	`2`	`import{withThemes}from"@react-theming/storybook-addon"`
`3`	`3`	`import{light,dark}from"../theme"`
`4`	`4`	`import{addDecorator}from"node_modules/@storybook/react"`
	`5`	`+import{createMemoryHistory}from"history"`
	`6`	`+import{unstable_HistoryRouterasHistoryRouter}from"react-router-dom"`
`5`	`7`
`6`	`8`	`addDecorator(withThemes(ThemeProvider,[light,dark]))`
`7`	`9`
	`10`	`+consthistory=createMemoryHistory()`
	`11`	`+`
	`12`	`+constrouterDecorator=(Story)=>{`
	`13`	`+return(`
	`14`	`+<HistoryRouterhistory={history}>`
	`15`	`+<Story/>`
	`16`	`+</HistoryRouter>`
	`17`	`+)`
	`18`	`+}`
	`19`	`+`
	`20`	`+addDecorator(routerDecorator)`
	`21`	`+`
`8`	`22`	`exportconstparameters={`
`9`	`23`	`actions:{`
`10`	`24`	`argTypesRegex:"^on[A-Z].*",`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import{Story}from"@storybook/react"`
`2`	`2`	`importReactfrom"react"`
`3`	`3`	`import{Workspace,WorkspaceProps}from"./Workspace"`
`4`		`-import{MockWorkspace}from"../../test_helpers"`
	`4`	`+import{MockOrganization,MockProject,MockWorkspace}from"../../test_helpers"`
`5`	`5`
`6`	`6`	`exportdefault{`
`7`	`7`	`title:"Workspace",`
`@@ -13,5 +13,7 @@ const Template: Story<WorkspaceProps> = (args) => <Workspace {...args} />`
`13`	`13`
`14`	`14`	`exportconstExample=Template.bind({})`
`15`	`15`	`Example.args={`
	`16`	`+organization:MockOrganization,`
	`17`	`+project:MockProject,`
`16`	`18`	`workspace:MockWorkspace,`
`17`	`19`	`}`

Comments

(0)