Commitdec6d31

authored

fix: avoid bad switch statement in license code (#20509)

Noticed this while trying to investigate a flake.Relates tocoder/internal#788

1 parente720afa commitdec6d31Copy full SHA for dec6d31

File tree

-6

lines changed

-6

lines changed

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -490,15 +490,15 @@ func LicensesEntitlements(`
`490`	`490`	`iffeatureArguments.ManagedAgentCountFn!=nil {`
`491`	`491`	`managedAgentCount,err=featureArguments.ManagedAgentCountFn(ctx,agentLimit.UsagePeriod.Start,agentLimit.UsagePeriod.End)`
`492`	`492`	`}`
`493`		`-switch {`
`494`		`-casexerrors.Is(err,context.Canceled)\|\|xerrors.Is(err,context.DeadlineExceeded):`
	`493`	`+ifxerrors.Is(err,context.Canceled)\|\|xerrors.Is(err,context.DeadlineExceeded) {`
`495`	`494`	`// If the context is canceled, we want to bail the entire`
`496`	`495`	`// LicensesEntitlements call.`
`497`	`496`	`returnentitlements,xerrors.Errorf("get managed agent count: %w",err)`
`498`		`-caseerr!=nil:`
`499`		`-entitlements.Errors=append(entitlements.Errors,`
`500`		`-fmt.Sprintf("Error getting managed agent count: %s",err.Error()))`
`501`		`-default:`
	`497`	`+}`
	`498`	`+iferr!=nil {`
	`499`	`+entitlements.Errors=append(entitlements.Errors,fmt.Sprintf("Error getting managed agent count: %s",err.Error()))`
	`500`	`+// no return`
	`501`	`+}else {`
`502`	`502`	`agentLimit.Actual=&managedAgentCount`
`503`	`503`	`entitlements.AddFeature(codersdk.FeatureManagedAgentLimit,agentLimit)`
`504`	`504`

Comments

(0)