- Notifications
You must be signed in to change notification settings - Fork917
Commitddb49df
fix: preserve parameter values when dynamic ordering changes (#18270)
## ProblemWhen creating a workspace from a template with dynamic parameterordering, parameter values are not displaying correctly when the orderchanges. This occurs when a parameter's `order` value depends on anotherparameter's value.**Example scenario:**```terraformdata "coder_parameter" "reorder" { name = "reorder" type = "bool" default = false order = 1}data "coder_parameter" "cpu" { order = data.coder_parameter.reorder.value ? 0 : 2 name = "cpu" type = "number" default = 4}```When the user toggles `reorder` from `false` to `true`, the `cpu`parameter moves from position 2 to position 0, but its value gets mixedup with the `reorder` parameter's value.## Root CauseThe issue was in `CreateWorkspacePageViewExperimental.tsx` whereparameters were rendered using array indices instead of parameter names:```typescript// Problematic codeconst parameterField = `rich_parameter_values.${index}`;const formValue = form.values?.rich_parameter_values?.[index]?.value || "";```When parameters are reordered:1. The `parameters` array order changes based on the new `order` values2. The `form.values.rich_parameter_values` array maintains the originalorder3. Array index-based lookup causes values to be mismatched## SolutionImplemented name-based lookup to ensure parameter values stay with theircorrect parameters:```typescript// Find parameter value by name instead of indexconst currentParameterValueIndex = form.values.rich_parameter_values?.findIndex( (p) => p.name === parameter.name) ?? -1;// Use the found index for form field mappingconst parameterFieldIndex = currentParameterValueIndex !== -1 ? currentParameterValueIndex : index;const parameterField = `rich_parameter_values.${parameterFieldIndex}`;// Get form value by name to ensure correct mappingconst formValue = currentParameterValueIndex !== -1 ? form.values?.rich_parameter_values?.[currentParameterValueIndex]?.value || "" : "";```## Testing- ✅ Created test script that validates the fix works correctly- ✅ Tested with the provided template showing dynamic parameter ordering- ✅ Verified parameter values persist correctly during reordering- ✅ Confirmed no TypeScript compilation issues## ImpactThis fix ensures that users can reliably use dynamic parameter orderingin their templates without losing parameter values when the orderchanges. This is particularly important for templates that useconditional parameter visibility and ordering based on user selections.---------Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>Co-authored-by: Jaayden Halko <jaayden@coder.com>1 parenta30a18f commitddb49df
File tree
1 file changed
+15
-2
lines changed- site/src/pages/CreateWorkspacePage
1 file changed
+15
-2
lines changedLines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
608 | 608 | | |
609 | 609 | | |
610 | 610 | | |
611 | | - | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
612 | 620 | | |
613 | 621 | | |
614 | 622 | | |
| |||
629 | 637 | | |
630 | 638 | | |
631 | 639 | | |
| 640 | + | |
632 | 641 | | |
633 | | - | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
634 | 647 | | |
635 | 648 | | |
636 | 649 | | |
| |||
0 commit comments
Comments
(0)